[MCOMPILER-542] rework log and conditions to run #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hboutemy
force-pushed
the
jorsol-MCOMPILER-542
branch
from
bd9efa9 to
efa180c
Compare
jorsol
requested changes
Nov 27, 2023
src/main/java/org/apache/maven/plugin/compiler/ModuleInfoTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java
Outdated
Show resolved
Hide resolved
hboutemy
force-pushed
the
jorsol-MCOMPILER-542
branch
from
efa180c to
29967bf
Compare
hboutemy
force-pushed
the
jorsol-MCOMPILER-542
branch
from
29967bf to
d14122a
Compare
jorsol
reviewed
Nov 28, 2023
| @@ -45,10 +53,11 @@ public ModuleVisitor visitModule(String name, int access, String version) { | |||
| @Override | |||
| public void visitRequire(String module, int access, String version) { | |||
| // Check if the module name matches the java/jdk modules | |||
| if (module.startsWith("java.") || module.startsWith("jdk.")) { | |||
| if (version != null && (module.startsWith("java.") || module.startsWith("jdk."))) { | |||
There was a problem hiding this comment.
This null check will preserve the current behavior when compiling from a newer JDK to an older target (eg. using JDK 11 to compile the module-info using --release 9).
In other words, it will not patch anything, while this is perfectly valid, the JDK-8318913 aims to modify this behavior to set the simple version always, I'm ok to preserve the current behavior and check later if we need to drop or not this null check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.